🐛 Surface wrapped test command failures#295
Closed
Robdel12 wants to merge 1 commit into
Closed
Conversation
Vizzly - Visual Test ResultsCLI Reporter - Waiting for buildNo builds received yet for this pull request.
|
Contributor
Author
|
Closing this after re-checking the CI failure path. The CLI already inherits the wrapped command stdout/stderr; the missing failure details came from the wrapped command running Vite in silent mode, which was fixed in the Vizzly app scripts. This PR only improved the wrapper sentence, so it is not the right fix for the observed issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When vizzly run wraps a failing test command, the original command output is already streamed above the Vizzly summary. The final CLI message was still just Test run failed, which made CI failures feel like the CLI had swallowed the real error and left reviewers without a clear next step.
Approach
This keeps the existing streaming behavior intact and makes the final wrapper message explicit: the wrapped test command failed, which exit code it returned, and that the original failure is in the command output above.
That avoids adding buffering or replay behavior around child process output, which would be riskier for interactive test runners and TTY-sensitive tools.
Confidence
The focused run-command test covers the new failure message, and Biome passes on the touched CLI files.